GtkLabel: Don't manually iterate over link list

There are various functions to access links based on their index for
a11y. We can spare quite a few lines of code by just using
g_list_nth_data instead of iterating over the list ourselves.

https://bugzilla.gnome.org/show_bug.cgi?id=765496

diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c
index a51d71f451183ed0c099547bd0538a52718b8582..caf031c46d044ebb81cfa82fba04de0ff077bc17 100644 (file)
--- a/gtk/gtklabel.c
+++ b/gtk/gtklabel.c
@@ -7048,19 +7048,13 @@ _gtk_label_get_link_uri (GtkLabel *label,
                          gint      idx)
 {
   GtkLabelPrivate *priv = label->priv;
-  gint i;
-  GList *l;
-  GtkLabelLink *link;
 
   if (priv->select_info)
-    for (l = priv->select_info->links, i = 0; l; l = l->next, i++)
-      {
-        if (i == idx)
-          {
-            link = l->data;
-            return link->uri;
-          }
-      }
+    {
+      GtkLabelLink *link = g_list_nth_data (priv->select_info->links, idx);
+      if (link)
+        return link->uri;
+    }
 
   return NULL;
 }
@@ -7113,24 +7107,18 @@ _gtk_label_get_link_at (GtkLabel *label,
 }
 
 void
-_gtk_label_activate_link (GtkLabel *label, 
+_gtk_label_activate_link (GtkLabel *label,
                           gint      idx)
 {
   GtkLabelPrivate *priv = label->priv;
-  gint i;
-  GList *l;
-  GtkLabelLink *link;
 
   if (priv->select_info)
-    for (l = priv->select_info->links, i = 0; l; l = l->next, i++)
-      {
-        if (i == idx)
-          {
-            link = l->data;
-            emit_activate_link (label, link);
-            return;
-          }
-      }
+    {
+      GtkLabelLink *link = g_list_nth_data (priv->select_info->links, idx);
+
+      if (link)
+        emit_activate_link (label, link);
+    }
 }
 
 gboolean
@@ -7138,19 +7126,12 @@ _gtk_label_get_link_visited (GtkLabel *label,
                              gint      idx)
 {
   GtkLabelPrivate *priv = label->priv;
-  gint i;
-  GList *l;
-  GtkLabelLink *link;
 
   if (priv->select_info)
-    for (l = priv->select_info->links, i = 0; l; l = l->next, i++)
-      {
-        if (i == idx)
-          {
-            link = l->data;
-            return link->visited;
-          }
-      }
+    {
+      GtkLabelLink *link = g_list_nth_data (priv->select_info->links, idx);
+      return link ? link->visited : FALSE;
+    }
 
   return FALSE;
 }